Skip to content

Update log timestamp format to include date.#414

Merged
Theodlz merged 1 commit intocesium-ml:mainfrom
antoine-le-calloch:origin/improve_logging
Mar 20, 2026
Merged

Update log timestamp format to include date.#414
Theodlz merged 1 commit intocesium-ml:mainfrom
antoine-le-calloch:origin/improve_logging

Conversation

@antoine-le-calloch
Copy link
Contributor

Proposition to update the log timestamp format to include the date.
It seems more logical to me when reading logs.

@stefanv
Copy link
Contributor

stefanv commented Mar 9, 2026

Yes, unclear why this hasn't been done in ten years 😂

@antoine-le-calloch
Copy link
Contributor Author

@Theodlz @stefanv (Tag you here since I can't add Reviewers/Assignees)

@Theodlz
Copy link
Collaborator

Theodlz commented Mar 9, 2026

Yes, unclear why this hasn't been done in ten years 😂

same thought crossed my mind. the missing dates caused me an immense amount of pain in prod over the years but I was too lazy to fix it I guess 😓

Thanks Antoine, that's a LGTM for me

@Theodlz Theodlz requested review from Theodlz and stefanv March 9, 2026 19:59
Copy link
Collaborator

@Theodlz Theodlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoine-le-calloch
Copy link
Contributor Author

@Theodlz @stefanv Can we merge this ? And update Skyportal with this new version of baselayer ?

@Theodlz Theodlz merged commit 48eb673 into cesium-ml:main Mar 20, 2026
3 checks passed
@antoine-le-calloch antoine-le-calloch deleted the origin/improve_logging branch March 20, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants