[DONT MERGE] Better-error-from-v0.4.1

[ekrembal]

No description provided.

[Copilot]

Pull Request Overview

A comprehensive update that implements better error propagation from background tasks to RPC streams. The change replaces blocking error handling with stream-based error forwarding to prevent tasks from silently failing in the background.

• Modifies signature and nonce generation methods to return Result<T, BridgeError> instead of T
• Updates error monitoring to propagate errors through channels instead of just logging them
• Enhances partial signature verification with optional environment variable controls

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
core/src/verifier.rs	Updated deposit_sign to return error results and added error monitoring
core/src/utils.rs	Enhanced monitor_standalone_task to forward errors through channels
core/src/test/musig2.rs	Updated test signatures to include public nonces for verification
core/src/rpc/verifier.rs	Added error handling for partial signature results and improved logging
core/src/rpc/parser/verifier.rs	Enhanced error messages with context information
core/src/rpc/parser/mod.rs	Simplified optional message parsing
core/src/rpc/operator.rs	Updated deposit_sign to return error results and added monitoring
core/src/rpc/aggregator.rs	Extensive refactoring for error propagation and signature verification
core/src/operator.rs	Updated deposit_sign signature and added error monitoring
core/src/musig2.rs	Added optional partial signature verification and updated function signatures
core/src/header_chain_prover.rs	Temporarily commented out genesis chain state hash validation
core/src/errors.rs	Added full internal status conversion methods
core/src/aggregator.rs	Removed unused aggregate_move_partial_sigs method

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Corrected spelling of 'aggregatod' to 'aggregated'.

Suggested change

	/// For each expected sighash, we collect a batch of public nonces from all verifiers. We aggregate and send aggregatod nonce and all public nonces (needed for partial signature verification) to the agg_nonce_sender. Then repeat for the next sighash.
	/// For each expected sighash, we collect a batch of public nonces from all verifiers. We aggregate and send aggregated nonce and all public nonces (needed for partial signature verification) to the agg_nonce_sender. Then repeat for the next sighash.

[Copilot]

Corrected spelling of 'aggregatedd' to 'aggregated'.

Suggested change

	/// Reroutes aggregated nonces and public nonces for each aggregatedd nonce to the signature aggregator.
	/// Reroutes aggregated nonces and public nonces for each aggregated nonce to the signature aggregator.

[Copilot]

[nitpick] The sentence structure is unclear. Consider: 'Collects partial signatures and corresponding public nonces from given stream and aggregates them. Each partial signature is also verified if PARTIAL_SIG_VERIFICATION is set to true.'

Suggested change

	/// Collects partial signatures and the corresponding public nonce from given stream and aggregates them, while aggregating each partial signature will also be verified if PARTIAL_SIG_VERIFICATION is set to true.
	/// Collects partial signatures and corresponding public nonces from given stream and aggregates them.
	/// Each partial signature is also verified if PARTIAL_SIG_VERIFICATION is set to true.

[Copilot]

[nitpick] The sentence structure could be improved. Consider: 'Aggregates partial signatures into a single signature and verifies it. If PARTIAL_SIG_VERIFICATION is set to true, each partial signature is also verified individually.'

Suggested change

	/// Aggregates the partial signatures into a single aggregated signature and verifies the aggregated signature. If PARTIAL_SIG_VERIFICATION is set to true, each partial signature will also be verified.
	/// Aggregates partial signatures into a single signature and verifies it. If PARTIAL_SIG_VERIFICATION is set to true, each partial signature is also verified individually.