Skip to content

Conversation

@atacann
Copy link
Contributor

@atacann atacann commented Oct 20, 2025

Apply review comments of cantina fixes

@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 13:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies review comments from a Cantina security audit, focusing on bug fixes and improvements identified during the review process.

  • Added a missing call to disprove_if_ready in the kickoff state machine
  • Fixed fee rate calculation to prevent division precision issues
  • Improved watchtower uniqueness check to use getter methods

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
core/src/states/kickoff.rs Added missing disprove_if_ready call in state machine logic
core/src/extended_bitcoin_rpc.rs Fixed fee rate calculation to prevent precision loss from division
core/src/deposit.rs Updated watchtower uniqueness check to use consistent getter methods
core/src/builder/transaction/operator_collateral.rs Added MIN_TAPROOT_AMOUNT import and updated condition for standard transactions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@atacann atacann marked this pull request as ready for review October 20, 2025 14:26
@atacann atacann merged commit dfed9af into main Oct 20, 2025
23 checks passed
@atacann atacann deleted the cantina-fixes-review-main branch October 20, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants