Allow to manage repositories in the scheduler #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjmerchante
force-pushed
the
manage-repositories
branch
3 times, most recently
from
ef91004 to
de04607
Compare
sduenas
requested changes
Feb 4, 2025
Member
sduenas
left a comment
sduenas
left a comment
There was a problem hiding this comment.
I think we should keep this simpler. The API will change a lot and we don't need to include behaviours or operations that we could remove.
| uri = CharField(max_length=MAX_SIZE_CHAR_FIELD) | ||
| datasource_type = CharField(max_length=MAX_SIZE_CHAR_FIELD) | ||
| datasource_category = CharField(max_length=MAX_SIZE_CHAR_FIELD) | ||
| task = OneToOneField(EventizerTask, on_delete=CASCADE, related_name="repository", null=True, default=None) |
Member
There was a problem hiding this comment.
This can be enough for now but in the future we would need a 0:N relationship.
jjmerchante
force-pushed
the
manage-repositories
branch
2 times, most recently
from
12801aa to
ace68ab
Compare
sduenas
force-pushed
the
manage-repositories
branch
from
ace68ab to
374778a
Compare
sduenas
requested changes
Feb 5, 2025
Member
sduenas
left a comment
sduenas
left a comment
There was a problem hiding this comment.
The main change I propose is to move datasources as an app at the same level of scheduler.
jjmerchante
force-pushed
the
manage-repositories
branch
from
374778a to
c230451
Compare
This commit introduces a new model, `Repository`, which allows easier management of repositories. With this model, repositories can be uniquely related to tasks. Signed-off-by: Jose Javier Merchante <[email protected]>
This commit adds two new API endpoints for managing repositories: - /scheduler/add_repository: This endpoint allows users to add a new repository for analysis. - /scheduler/repositories: This endpoint provides a list of available repositories in GrimoireLab along with task information. It includes filtering options for backend, category, and URI. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
manage-repositories
branch
from
c230451 to
2a2e355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new model and two new endpoints to manage repositories in GrimoireLab core:
/scheduler/add_repository: This endpoint allows users to add a new repository for analysis. If the repository already exists, it is updated.
/scheduler/repositories: This endpoint provides a list of available repositories in GrimoireLab and task information. It includes filtering options for the backend, category, and URI.