-
Notifications
You must be signed in to change notification settings - Fork 5
First version of the scheduler UI #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good but there are some things that can improve it:
-
Dates should be in format
yyyy-mm-dd timenow the show something like15/4/2024, 12:01:42 -
Not sure how to show it but I think the task entry on the list should show the repository that it's analyzing.
-
The task should be clear what does the date mean. I think we should say something like last run or similar.

-
The status bar on story book is very small so it's hard to see that the colors change to the right ones:

-
The job entry on the lists should also have the time when it run.
-
The job entry should have a job number too, to make easier for the user to look for a job

|
It'll be great if the ui can be accessed when the developer mode is running. i.e. when |
ccaef99 to
3ba5e14
Compare
|
I updated the PR to make the UI compatible with the latest changes and added the collection of static files to the |
Adds the initial files needed to configure the UI. Signed-off-by: Eva Millán <[email protected]>
Adds pages to visualize a list of task and a single task. The single task includes a view for a list of its jobs and the detailed view for one job. Signed-off-by: Eva Millán <[email protected]>
Collects and installs static files when the 'admin' command is run. The UI static files are generated using 'yarn build'. Signed-off-by: Eva Millán <[email protected]>
3ba5e14 to
d968dbd
Compare
sduenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds the configuration needed to start the Vue 3 project, including Storybook, Vuetify and Cypress. The build tool is Vite because vue-cli is no longer recommended for new projects. It also includes the initial pages to visualize and schedule git tasks and their jobs.
Run the UI in development mode:
Build for production:
Run Storybook: