Skip to content

Conversation

@evamillan
Copy link
Contributor

This PR adds the configuration needed to start the Vue 3 project, including Storybook, Vuetify and Cypress. The build tool is Vite because vue-cli is no longer recommended for new projects. It also includes the initial pages to visualize and schedule git tasks and their jobs.

Run the UI in development mode:

yarn serve

Build for production:

yarn build

Run Storybook:

yarn storybook

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but there are some things that can improve it:

  • Dates should be in format yyyy-mm-dd time now the show something like 15/4/2024, 12:01:42

  • Not sure how to show it but I think the task entry on the list should show the repository that it's analyzing.

  • The task should be clear what does the date mean. I think we should say something like last run or similar.
    imagen

  • The status bar on story book is very small so it's hard to see that the colors change to the right ones:
    imagen

  • The job entry on the lists should also have the time when it run.

  • The job entry should have a job number too, to make easier for the user to look for a job
    imagen

@sduenas
Copy link
Member

sduenas commented Nov 15, 2024

It'll be great if the ui can be accessed when the developer mode is running. i.e. when grimoirelab run server --dev command is run.

@evamillan
Copy link
Contributor Author

I updated the PR to make the UI compatible with the latest changes and added the collection of static files to the grimoirelab admin setup command.

Adds the initial files needed to configure the UI.

Signed-off-by: Eva Millán <[email protected]>
Adds pages to visualize a list of task and a single
task. The single task includes a view for a list of
its jobs and the detailed view for one job.

Signed-off-by: Eva Millán <[email protected]>
Collects and installs static files when the 'admin'
command is run.
The UI static files are generated using 'yarn build'.

Signed-off-by: Eva Millán <[email protected]>
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit d359332 into chaoss:main Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants