-
Notifications
You must be signed in to change notification settings - Fork 5
Add structured logs #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
381a613
to
0f63865
Compare
35c09b9
to
e92e072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I include some comments about the handlers and future improvements.
8b14370
to
4428a93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a small change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Organizing log data in a structured format makes easier to read and analyze them. With this commit, log messages will always have a structured format. The default mode is to print the messages to the console in a plain format, but it can also be configured to print them in JSON format. We have added structured logs to GrimoireLab using the 'structlog' package. By default, tests will run silent. If developers want to get log messages printed to the console, activate the environment variable 'GRIMOIRELAB_TESTING_VERBOSE'. Signed-off-by: Santiago Dueñas <[email protected]>
Some messages were updated to follow the structured format. Signed-off-by: Santiago Dueñas <[email protected]>
a9dc7ec
to
3fb5072
Compare
Organizing log data in a structured format makes easier to read and analyze them.
With this PR, log messages will always have a structured format. The default mode is to print the messages to the
console in a plain format, but it can also be configured to print them in JSON format.
We have added structured logs to GrimoireLab using the 'structlog' package.