Store events in a Redis stream instead of a list #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjmerchante
force-pushed
the
redis-stream
branch
2 times, most recently
from
153f64b to
6e5e0d9
Compare
jjmerchante
force-pushed
the
redis-stream
branch
4 times, most recently
from
a962b7d to
7cb5cee
Compare
jjmerchante
force-pushed
the
redis-stream
branch
from
7cb5cee to
3843158
Compare
jjmerchante
force-pushed
the
redis-stream
branch
from
3843158 to
7a47edc
Compare
sduenas
requested changes
Jan 15, 2025
Member
sduenas
left a comment
sduenas
left a comment
There was a problem hiding this comment.
I wonder if you can reduce the PR just to the scope of writing data to the events stream. I think we can add the tasks that process data later.
jjmerchante
force-pushed
the
redis-stream
branch
from
7a47edc to
6365565
Compare
Contributor
Author
|
I updated the PR to include only the change that inserts data in the stream. I also removed the file grimoirelab-dev that was not being used because the contents were moved to runner/commands/run/ |
sduenas
requested changes
Jan 17, 2025
jjmerchante
force-pushed
the
redis-stream
branch
4 times, most recently
from
d9c3e88 to
bbd89c7
Compare
This commit updates the method of storing events in Redis for later consumption. Events are now added to a Redis Stream, allowing different types of consumers to process the items for various purposes. The trade-off is that the stream has a fixed length, causing older items to be deleted when new items are added. Signed-off-by: Jose Javier Merchante <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the method of storing events in Redis for later consumption.
Events are now added to a Redis Stream, allowing different types of consumers to process the items for various purposes. The trade-off is that the stream has a fixed length, causing older items to be deleted when new items are added.