[ui] Improve merge recommendations #1000
Conversation
sduenas
left a comment
sduenas
left a comment
There was a problem hiding this comment.
I think this is a good approach but I have some comments:
- I think we should leave just one set of recommendations per individual. I understand improves the pagination but it makes it messy.
- I found useful the old behavior to say when an individual wasn't the same of another one. How can we keep that?
sortinghat/core/schema.py
Outdated
| query = MergeRecommendation.objects.filter(applied=None) | ||
|
|
||
| query = query.order_by('created_at') | ||
| query = query.order_by('individual1__mk') |
There was a problem hiding this comment.
I think we should short them by the number suggestions. I think those are the ones that could be more problematic (snowballs), so we should give them more importance.
evamillan
force-pushed
the
order-recs
branch
from
c9365e2 to
07b1aa3
Compare
|
I updated the PR, keeping one set of recommendations per page like before, but ordering by number of recommendations and showing all of the individual's recommendations at once. 
|
evamillan
force-pushed
the
order-recs
branch
from
07b1aa3 to
b447473
Compare
sduenas
left a comment
sduenas
left a comment
There was a problem hiding this comment.
I think it's more clear now hot to merge identities, however, I still think it's not clear what it means to click the checkbox. I understood the user needs to do two actions to say the identities are the same or not. It can't be done on the same action. That's probably a waste of time. Why don't we try to do everything on the same action?
For example, each card can have an ok or a x icons. The user can click on these to either say the individual is the same or not. After the review, the user just need to click on another button called "Confirm" that will merge the individuals set to ok. The others will be stored on the table that keeps which identities aren't the same, so they won't be suggested again. The button "ask me later" can be still available.
What do you think?
evamillan
force-pushed
the
order-recs
branch
3 times, most recently
from
7ef2253 to
c34cd30
Compare
|
I replaced the checkboxes with buttons to make the actions being applied clearer. 
|
The "ask me later" must apply individually. It's 3 options per recommendation. |
"Ask me later" is for doing nothing with any of the recommendations. If you don't want to do anything with one of them, just don't click on any of the options. |
Orders the list of merge recommendations by the individual's number of suggestions. Signed-off-by: Eva Millán <[email protected]>
Recommendations belonging to the same individual are grouped and can be managed in batches. Signed-off-by: Eva Millán <[email protected]>
3 participants
This PR changes the merge recommendations modal to show more than one at a time. The recommendations are ordered by individual so they can be grouped on the UI to manage them in batches. Users can select which recommendations to apply or dismiss using checkboxes. The list of recommendations is also paginated to improve the navigation.