Fix comparing offset-naive and offset-aware datetimes #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjmerchante
force-pushed
the
fix-jobs-table
branch
from
a596a9b to
c89ca11
Compare
Replaced `datetime.datetime.utcnow()` with `datetime_utcnow()` to ensure consistent offset-aware datetime comparisons when sorting jobs by `enqueued_at` and avoid errors. Replace all creations of utc datetime with the grimoirelab_toolkit datetime_utcnow method for consistency. Signed-off-by: Jose Javier Merchante <[email protected]>
sduenas
force-pushed
the
fix-jobs-table
branch
from
c89ca11 to
b0f1950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
datetime.datetime.utcnow()withdatetime_utcnow()to ensure consistent offset-aware datetime comparisons when sorting jobs byenqueued_atto avoid this error:Replace all creations of utc datetime with the
grimoirelab_toolkit.datetime_utcnowfunction for consistency.