Fix error for existing identities found during importing process #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
force-pushed
the
fix-notfound-error-importer
branch
from
ff4836f to
d36493d
Compare
…rocess When an identity already stored in the database was found, the identity weren't properly handled. The code caught the exception but the database object of that identity couldn't be found. To find an identity we need the UUID but were using the value returned on the 'AlreadyExistsError' which is not the UUID, it's just the values of the duplicated entry (name, email, etc). To fix the error, instead of using the function 'find_identity_by_uuid', we look for it using Django's ORM to look for the tuple (source, name, email, username) because we don't know the UUID of the identity already inserted. Signed-off-by: Santiago Dueñas <[email protected]>
sduenas
force-pushed
the
fix-notfound-error-importer
branch
from
d36493d to
5e630fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an identity already stored in the database was found, the identity weren't property handled.
The code caught the exception but the database object of that identity couldn't be found. To find an identity we need the UUID but were using the value returned on the
AlreadyExistErrorwhich is not the UUID, it's just the values of the duplicated entry (name, email, etc).To fix the error, instead of using the function
find_identity_by_uuid, we look for it using Django's ORM to look for the tuple (source, name, email, username) because we don't know the UUID of the identity already inserted.