feat: add PSR-18/PSR-17 HTTP client injection support#127
Open
feat: add PSR-18/PSR-17 HTTP client injection support#127
Conversation
Allow injecting a PSR-18 ClientInterface directly into ChargebeeClient without implementing the Chargebee-specific HttpClientFactory interface. PSR-17 request/stream factories can optionally be provided; when omitted, php-http/discovery auto-discovers any installed implementation. New: src/HttpClient/PsrClientAdapter.php wraps a PSR-18 client and builds PSR-7 requests using injected or discovered PSR-17 factories. The existing HttpClientFactory injection path and the default GuzzleFactory are unchanged — fully backward compatible. New dependencies (require): - php-http/discovery ^1.0 - psr/http-factory ^1.0 Note: guzzlehttp/guzzle remains in require for v4.x compatibility. Removing it is deferred to the next major version. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ychedemois
reviewed
Feb 24, 2026
cb-srinaths
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow injecting a PSR-18 ClientInterface directly into ChargebeeClient without implementing the Chargebee-specific HttpClientFactory interface. PSR-17 request/stream factories can optionally be provided; when omitted, php-http/discovery auto-discovers any installed implementation.
New: src/HttpClient/PsrClientAdapter.php wraps a PSR-18 client and builds PSR-7 requests using injected or discovered PSR-17 factories.
The existing HttpClientFactory injection path and the default GuzzleFactory are unchanged — fully backward compatible.
New dependencies (require):
Include any additional information that might be helpful in reviewing the changes introduced by this pull request.