docs: clarify CALL events #7188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/refine-call-docs
branch
4 times, most recently
from
9cc323b to
64c651f
Compare
iequidoo
reviewed
Sep 17, 2025
| * If the call was accepted, this is a "hangup". | ||
| * | ||
| * All participant devices get informed about the ended call via #DC_EVENT_CALL_ENDED. | ||
| * All participant devices get informed about the ended call via #DC_EVENT_CALL_ENDED unless they are contact requests. |
There was a problem hiding this comment.
Do i correctly understand that for contact requests prepare_send_msg() fails so they aren't informed about the ended call? Shouldn't we explicitly check Chat::why_cant_send_ex() and handle this w/o throwing an error? I just don't see any special code for this in Context::end_call()
There was a problem hiding this comment.
the situation is not that bad - not being informed about the end of the call can happen anyways for many reasons and needs to be handled (which is done by the timeout)
however, it is still unclear what we want to do in case of contact requests, that needs to be figured out when other things are settled.
this PR is only about documenting the current state
Co-authored-by: iequidoo <[email protected]>
r10s
force-pushed
the
r10s/refine-call-docs
branch
from
d072677 to
9cb3811
Compare
adbenitez
approved these changes
Oct 1, 2025
iequidoo
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR clarifies some events, also updating to recent changes.
see changed code for details