Skip to content

Conversation

iequidoo
Copy link
Collaborator

@iequidoo iequidoo commented Sep 14, 2025

bcc_self=0 means that the user disabled it or it's a chatmail setup with the only device and w/o
backups. If a backup is made someday, old messages not marked as IMAP-seen aren't a problem and new
ones are marked as IMAP-seen.

For bots, particularly multi-device ones (which are a rare case), probably no sane logic can be
built on the "seen" message status. Moreover, if the user has additionally a bot that reads incoming
messages, it doesn't mean that the user doesn't want to read them too.

Also don't mark a message as IMAP-seen just if it already exists on the device as this doesn't mean
that it exists on another device.

Also don't mark MDNs and DSNs as IMAP-seen. Marking MDNs as seen is useless, they shouldn't be
displayed by any MUA. Auto-marking DSNs as seen should be avoided because the user may want to see
them in another MUA.

@iequidoo iequidoo mentioned this pull request Sep 14, 2025
@iequidoo iequidoo marked this pull request as draft September 14, 2025 09:09
@iequidoo iequidoo force-pushed the iequidoo/markseen_on_imap_table branch 3 times, most recently from d8e2b9f to 73d167b Compare September 15, 2025 10:05
@iequidoo
Copy link
Collaborator Author

iequidoo commented Sep 15, 2025

test_markseen_message_and_mdn fails and it has a comment:

# Please only change this test if you are very sure that it will still catch the issues it catches now.
# We had so many problems with markseen, if in doubt, rather create another test, it can't harm.

Probably this means that MDNs must be marked as \Seen for some reason which is not documented unfortunately.
...
53fed91 (Fix marking read receipts as seen) added this test .
...
I still decided to modify the test. But if MDNs are marked as seen currently for a good reason, i'll revert this part of the PR. CC @Hocuri

@iequidoo iequidoo marked this pull request as ready for review September 15, 2025 10:31
@iequidoo iequidoo force-pushed the iequidoo/markseen_on_imap_table branch from 73d167b to 4acbf1f Compare September 16, 2025 06:28
bcc_self=0 means that the user disabled it or it's a chatmail setup with the only device and w/o
backups. If a backup is made someday, old messages not marked as IMAP-seen aren't a problem and new
ones are marked as IMAP-seen.

For bots, particularly multi-device ones (which are a rare case), probably no sane logic can be
built on the "seen" message status. Moreover, if the user has additionally a bot that reads incoming
messages, it doesn't mean that the user doesn't want to read them too.
…ate < InSeen

The message may not exist on another device.
Marking MDNs as seen is useless, they shouldn't be displayed by any MUA.
@iequidoo iequidoo force-pushed the iequidoo/markseen_on_imap_table branch from 4acbf1f to ab81f71 Compare September 16, 2025 06:57
@iequidoo iequidoo requested a review from Hocuri September 16, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant