add new fields on inboxes for ai review settings #1331
Conversation
Pascal-Delange
force-pushed
the
pascal/mar-1297-implement-the-backend-workflows-for-case-events-that-trigger-2
branch
from
f4251f7 to
7fbaf1a
Compare
| } | ||
|
|
||
| suite.blobRepo.On("GetBlob", suite.ctx, "test-bucket-url", aiCaseReview.FileTempReference). | ||
| suite.blobRepo.On("GetBlob", mock.Anything, "test-bucket-url", aiCaseReview.FileTempReference). |
There was a problem hiding this comment.
Rationale behind this change and below: equality check on the context was breaking if I add tags on the logger and re-inject it into the context. The compiler won't let us pass something else than a context anyway so no need to test this specifically.
| } | ||
| if hasAiCaseReviewEnabled { | ||
| aiCaseReview := models.NewAiCaseReview(caseId, d.caseManagerBucketUrl) | ||
| err = d.repository.CreateCaseReviewFile(ctx, tx, aiCaseReview) |
There was a problem hiding this comment.
NB: I did a small refactor here. The case review file is now created within the worker - there was no strong reason for needing to create it before, and this way it's not repeated in every place we need to trigger the workflow. We still generate the id of it in advance (so that the worker execution remains idempotent).
Pascal-Delange
force-pushed
the
pascal/mar-1297-implement-the-backend-workflows-for-case-events-that-trigger-2
branch
from
04ee5e3 to
4d06625
Compare
| if !l.CaseAutoAssign { | ||
| o.CaseAutoAssign = Restricted | ||
| } | ||
| if !l.CaseAiAssist { |
There was a problem hiding this comment.
This needs to be commented to actually test the change in local dev mode (staging should be fine), until the prod release is deployed (license server updated).
|
@OrriMandarin can be re-read |
Pascal-Delange
force-pushed
the
pascal/mar-1297-implement-the-backend-workflows-for-case-events-that-trigger-2
branch
from
d42a33b to
41dea19
Compare
Pascal-Delange
force-pushed
the
pascal/mar-1297-implement-the-backend-workflows-for-case-events-that-trigger-2
branch
from
f9fc171 to
df73fa9
Compare
…est, with the new inbox settings
…sage. Rewrite HasAiCaseReviewEnabled
Co-authored-by: Léo JI <[email protected]>
Pascal-Delange
force-pushed
the
pascal/mar-1297-implement-the-backend-workflows-for-case-events-that-trigger-2
branch
from
df73fa9 to
8c333a5
Compare
Pascal-Delange
deleted the
pascal/mar-1297-implement-the-backend-workflows-for-case-events-that-trigger-2
branch
Some other minor comments: see inline comments below.