Skip to content

fix: add input type validation to isHtml utility #4523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add input type validation to isHtml utility #4523

wants to merge 1 commit into from

Conversation

@Mallikarjun-0
Copy link

@Mallikarjun-0 Mallikarjun-0 commented Apr 12, 2025 •
edited
Loading

This PR improves the isHtml function in utils by adding a type check to ensure the input is a string. This prevents runtime errors when non-string values (like arrays or objects) are passed to the function.

Example code:

import { isHtml } from 'cheerio/utils';
const str = '<html></html>';

console.log(isHtml(str));    // true

const arr = JSON.parse(' {"html" : ["<", "html", ">", "<", "/", "html", ">"]}');
console.log(isHtml(arr.html));    // Error
  • The first call to isHtml returns true, but in the second call it throws an runtime error as charCodeAt() is not defined for arrays.
  • An explicit type check in the function isHtml() can prevent unexpected runtime crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Mallikarjun-0