(#3600) Handle non-ASCII passwords with legacy encoding fallback #3762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Add a method to convert passwords to NetworkCredential using codepage 1252 encoding to support non-ASCII characters in credentials. This addresses issues with encoding mismatches in .NET 4.8.1 that cause incorrect password handling.
Update credential retrieval to use this conversion method, falling back to the original password on retry attempts to maintain compatibility.
Add tests verifying correct username and legacy-encoded password handling for non-ASCII characters in explicit and implicit credential scenarios.
Motivation and Context
Even when a user is using a password with non-ascii characters, we would still want the user to be able to connect to a remote source, even when
Testing
øæåéèàù
)Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3600