Skip to content

(#3641) Correctly identify root of drive sources #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

(#3641) Correctly identify root of drive sources #3788

wants to merge 3 commits into from

Conversation

corbob
Copy link
Member

@corbob corbob commented Sep 17, 2025 •
edited
Loading

Description Of Changes

Update the lookup of a source when the source was requested as . and working directory is the root of a drive.

Motivation and Context

When a source is specified as . and we're at the root of the drive, sometimes we get the path as c: which when treated as a repository source does not resolve correctly.

Testing

  • Run through Test Kitchen here
  • Run the tests from this PR against the develop branch CLI through Test Kitchen here

Operating Systems Testing

  • Windows 11 - Manual testing
  • Windows Server 2016 - Test Kitchen
  • Windows Server 2019 - Test Kitchen

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

@corbob corbob self-assigned this Sep 17, 2025
@corbob corbob force-pushed the 3641-fix-drive-root-sources branch 3 times, most recently from 1d62d32 to 9345924 Compare September 17, 2025 18:28
@corbob corbob marked this pull request as ready for review September 17, 2025 18:32
corbob
corbob commented Sep 17, 2025
View reviewed changes
corbob
corbob commented Sep 17, 2025
View reviewed changes
@corbob corbob requested a review from vexx32 September 22, 2025 17:34
vexx32
vexx32 reviewed Sep 22, 2025
View reviewed changes
@corbob
(chocolatey#3641) Ensure root drive sources can be identified
aa9354e
@corbob
(chocolatey#3641) Tests ensuring drive root resolution
54f2f0a 
This commit adds tests to ensure a source of '.' at the root of a drive
resolves correctly.
@corbob corbob force-pushed the 3641-fix-drive-root-sources branch from 9345924 to 54f2f0a Compare September 22, 2025 19:12
@corbob
(chocolatey#3228) Update test to expect trailing separator
46df17a 
With the implementation of appending a directory separator to the source
when it doesn't already end in one, this caused the comparison of a test
to failure. This commit updates that expectation to include the trailing
directory separator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vexx32 vexx32 vexx32 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@corbob corbob

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot use the source . when running from the root of a drive

2 participants

@corbob @vexx32