Check for successful node creation missing after merge#11
Open
ixisandyr wants to merge 4 commits intochriscohen:masterfrom
Open
Check for successful node creation missing after merge#11ixisandyr wants to merge 4 commits intochriscohen:masterfrom
ixisandyr wants to merge 4 commits intochriscohen:masterfrom
Conversation
Add support for 'Video' field widgets.
Was able to override but it was never called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
It looks like there was an issue merging a couple of pull requests regarding createNode().
The first merge d67a653 added the seeCreateNodeWasSuccessful() function and called it in createNode(), but in the second commit 7aeda8f the call to seeCreateNodeWasSuccessful() was removed.
This means we're not able to override seeCreateNodeWasSuccessful(). Well, we can but it's never called.
This PR should put the call back in.
Thanks,
Andy.