Draft
Conversation
From the original paper:
The compactness of the recommended solutions is due to the use of nested
equations to compute elliptic terms and of only three trigonometric functions:
sine, cosine, and arc tangent. Nesting reduces the number of operations involving
storage and retrieval of intermediate results (particularly when programming)
in assembly language), reduces the length of the program and the time of execution,
and minimizes the possibility of underflow.
TODO: benchmarking and performance analysis to validate that this change
is appropriately taken advantage of by modern engines such as V8 and
Spidermonkey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the original paper:
I'm marking this PR as a draft, pending benchmarking verification that these changes are actually relevant given the introspective ability of today's compilers, but I strongly suspect it's at least probable that it will make a difference and take full advantage of the design that these equations have had since the start.