Skip to content

Conversation

@bylicaatgoogle
Copy link
Contributor

This adds firebase config files and also one check to not do any bundle stuff when building in firebase studio (because there are no security keys available there).

@edman
Copy link
Contributor

edman commented Jun 25, 2025

This adds firebase config files and also one check to not do any bundle stuff when building in firebase studio (because there are no security keys available there).

It's not just because there are no keys. Without that if condition vite will only output the signed bundle and the .well-known folder to dist/, not the static HTML/JS/CSS files you need to show a page when someone visits iwa-sink.web.app

I think we should make that intent more clear, not as a side effect of being in firebase studio or not.

e.g.

if (process.env.BUILD_TYPE === 'release') {
  // ... add the wbn plugin
}

and we have to run BUILD_TYPE="release" pnpm run build to make it generate a signed bundle, while just pnpm run build will generate the static assets.

We could also keep the current code and use NODE_ENV instead . That is,NODE_ENV="dev" pnpm run build to generate the static assets.

@@ -0,0 +1,1174 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you want to check this file in too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the industry standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants