You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 13, 2019. It is now read-only.
This makes me wonder why we need both fatal and error. error, if it worked correctly, would look exactly like fatal. fatal, to me, has the connotation of not permitting any further code to execute, so maybe it should raise an exception instead? Only that then we wouldn't need fatal at all, the user could just use raise (and we'd even display that exception nicely formatted.)
From my experience, fatal logging is just logging, and the exit is left up to the calling code. Fatal is basically some sugar to state why it shut down
Well, where I come from (Go), log.Fatal will actual exit the program, too.
Anyway, if "fatal logging is just logging", we should still determine how it would be different from "error logging", which would also use !! and be red. If they look exactly the same, we don't need both. Now the question is whether we should make one of the two look different, or if one of them should be dropped completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for fatal logging level - fixes #141