Refactor subquery syntax in tests for clarity and consistency #8384
+10
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8384 +/- ##
=======================================
Coverage 88.79% 88.80%
=======================================
Files 287 287
Lines 63236 63237 +1
Branches 7927 7927
=======================================
+ Hits 56151 56156 +5
+ Misses 4754 4750 -4
Partials 2331 2331 🚀 New features to boost your workflow:
|
m3hm3t
force-pushed
the
m3hm3t/test_reduce_flaky
branch
from
bc6949c to
45e80c2
Compare
m3hm3t
force-pushed
the
m3hm3t/test_reduce_flaky
branch
from
d8c8bcb to
8284462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Refactor subquery syntax in tests for clarity and consistency
Reduce regression test flakiness by making query output deterministic.
Add a stable
ORDER BY(on the row key) to the test query so result ordering is guaranteed across runs/plans, preventing intermittent diffs caused by planner/executor changes.