ValueEnum fallback #5886
Draft
ValueEnum fallback #5886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModProg
force-pushed
the
value-enum-fallback
branch
from
955dabc to
993bc8f
Compare
ModProg
force-pushed
the
value-enum-fallback
branch
from
993bc8f to
c567f0c
Compare
Member
|
Note that we ask for the focus to be on Issues until a design is settled before PRs. As such, I've marked this as a Draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #5885 if
EnumValueParserwere actually usingValueEnum::from_strinstead of apparently shipping it's own implementation here: https://docs.rs/clap_builder/4.5.26/src/clap_builder/builder/value_parser.rs.html#1119-1135 not sure what the best remedy is... supporting fallback explicitly in theValueEnumtrait? or makingEnumValueParserrespectValueEnum::from_str.