fix(dia.Graph): pass options to batch:start and batch:stop events consistently #3153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sistently Ensure that options passed to Graph methods are forwarded to both batch:start and batch:stop events. Previously some methods passed options to startBatch but not stopBatch, or vice versa. Methods fixed: - clear() - removeCells() - removeCell() - syncCells() - _replaceCell() - transferCellEmbeds() - transferCellConnectedLinks() Co-Authored-By: Claude Opus 4.5 <[email protected]>
zbynekstara
approved these changes
Jan 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes an inconsistency in the dia.Graph class where options passed to various methods were not being consistently forwarded to both batch:start and batch:stop events. Previously, some methods only passed options to startBatch but not stopBatch, causing incomplete event data.
Changes:
- Fixed 7 methods to consistently pass options to both batch events:
clear(),removeCells(),removeCell(),syncCells(),_replaceCell(),transferCellEmbeds(), andtransferCellConnectedLinks() - Added comprehensive test coverage for all affected methods plus existing correctly-implemented methods (
addCells()andsetDefaultLayer())
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/joint-core/src/dia/Graph.mjs | Fixed 7 methods to pass options parameter to both startBatch() and stopBatch() calls consistently |
| packages/joint-core/test/jointjs/graph.js | Added comprehensive test suite with 9 tests verifying options are passed to both batch events for all relevant methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
batch:startandbatch:stopeventsstartBatchbut notstopBatch, causing inconsistent event dataclear(),removeCells(),removeCell(),syncCells(),_replaceCell(),transferCellEmbeds(),transferCellConnectedLinks()Test plan
yarn test-client -- --file=test/jointjs/graph.js🤖 Generated with Claude Code