feat(joint-react): add link theme properties and containers storybook #3161
+2,027
−370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update all storybook examples to use `color` theme property instead of `attrs.line.stroke` for link styling - Add `mapDataToLinkAttributes` to stories that need custom link types (standard.DoubleLink, standard.ShadowLink) or custom attrs - Store theme properties (color, width, sourceMarker, targetMarker) in cell.data for proper bidirectional sync between React state and graph - Update tests to use new theme properties and reflect stored data structure Stories updated: - with-minimap: uses `color` property - with-resizable-node: uses `color` property - with-list-node: uses `color` property - with-rotable-node: uses `color` property - with-svg-node: uses `color` property - with-cell-actions: uses `color` property with dynamic updates - with-build-in-shapes: uses mapDataToLinkAttributes for custom types - with-link-tools: uses mapDataToLinkAttributes for strokeDasharray - with-custom-link: uses mapDataToLinkAttributes for custom LinkModel - with-selection: uses mapDataToLinkAttributes and theme properties Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
color,width,sourceMarker,targetMarker,className,patternattrsusage from storybook files in favor of theme propertiesparentproperty support for element embeddingLink Theme Properties
Links now support these theme properties out of the box:
color- stroke color (default:#333333)width- stroke width (default:2)sourceMarker/targetMarker- marker presets (arrow,arrow-open,circle,circle-outline,diamond,bar,cross,none) or customdia.SVGMarkerJSONclassName- CSS class for the link linepattern- stroke dash pattern (e.g.,'5,5'for dashed)Containers Storybook
New example showing:
parentpropertyembeddingModePaper option for drag-and-drop embeddingvalidateEmbeddingcallback to control which elements can be containersTest plan
🤖 Generated with Claude Code