-
Notifications
You must be signed in to change notification settings - Fork 920
Delete old BBR and pacer implementations in the recovery/congestion directory. #2297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
483dd33 to
c40a4d7
Compare
But this PR deletes brr and brr2? What about switching to brr3? Other users report much better experiences with brr than cubic, what are those big known problems? |
The main motivation behind this PR is to delete the pacer in the congestion directory. Since BBR implementations in that directory have a hard dependency on it, I think it is time for them to also be deleted. All of our investments are on making the bbr2 implementation in the gcongestion directory work well even in cases where Linux TxTime is not available. I have several planned changes in the near future to fix some recently found bugs and make this implementation closer to the BBR RFC draft. The config option to select "bbr2" still works. I can also keep the "bbr" option, but point it to the bbr2 implementation in the gcongestion directory. |
8821003 to
dcb490d
Compare
LPardue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo nits
Eventually "bbr" could be the main name provided and will refer to the latest and greatest version of the code as we try to converge the implementation with the BBR RFC IETF draft
There are big known problems in these implementations.
We recommend use of: