fix: resolve conditional React Hook calls in Link and Script shims#223
Open
haddoumounir wants to merge 1 commit intocloudflare:mainfrom
Open
fix: resolve conditional React Hook calls in Link and Script shims#223haddoumounir wants to merge 1 commit intocloudflare:mainfrom
haddoumounir wants to merge 1 commit intocloudflare:mainfrom
Conversation
Move early returns after all hook calls to satisfy the Rules of Hooks. - link.tsx: the dangerous-scheme early return was before useState/useRef/ useEffect/useCallback/useMemo — moved it to after all hooks - script.tsx: the SSR early return was before useEffect — moved useEffect before the check since it never runs during SSR anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useState,useRef,useEffect,useCallback,useMemo), making them conditional. Moved the check to a boolean flag before hooks and the early return to after all hooks.typeof window === "undefined") was beforeuseEffect, making it conditional. MoveduseEffectbefore the SSR check since it never runs during SSR anyway.Test plan
<Link>(e.g.javascript:hrefs render inert<a>)<Script>SSR rendering still works forbeforeInteractivestrategy