Python: Remove workerd runtime frames from the top of stack trace #5542
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/trim-python-stack-trace
branch
from
e9bac48 to
9c10fc8
Compare
Python tracebacks include some frames that are not related to user code but are in the workerd runtime. This trims them off.
hoodmane
force-pushed
the
hoodmane/trim-python-stack-trace
branch
from
9c10fc8 to
cec28c3
Compare
dom96
approved these changes
Nov 19, 2025
Contributor
dom96
left a comment
dom96
left a comment
There was a problem hiding this comment.
Looks good, though I think it would be wise to add a test to ensure the tracebacks we do get contain what we expect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python tracebacks include some frames that are not related to user code but are in the workerd runtime. This trims them off.