Skip to content

Conversation

jakubadamw
Copy link
Contributor

Per the definition in https://github.com/cloudflare/workerd/blob/4fb4dbd88d30ff293267680d85a31ddef94fd9b6/types/defines/cf.d.ts#L171-L295.

This is based on the existing #233 authored by @seeekr, with some improvements and the completion of the set of properties supported.

@jakubadamw
Copy link
Contributor Author

@zebp any chance this could be reviewed? 🙂

Seems like there generally is a lot of outstanding PRs open and ready to be reviewed. I wonder what the best process of getting one's PR reviewed and merged is here? I think it would make sense to perhaps document the process in the README or, otherwise, external contributors may get discouraged from getting involved, seeing their contributions not picked up for review long after submission? (General observation, nothing personal!)

@jakubadamw jakubadamw force-pushed the fetch-add-cf-image-property branch from 38ca3a0 to 76593e5 Compare August 15, 2023 20:28
Copy link
Member

@zebp zebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes needed, but looks like it's on the right track.

And yeah I think you hit the nail on the head about the PRs, there's definitely more that should be done to make sure PRs don't stack up and get reviewed in a more timely manner. I like the suggestion of documenting a process for contribution, but I also will start to be more active in reviewing and dealing with issues. In the future please feel free to ping me directly, my Github inbox is a mess but any direct pings give me a notification on my phone that I do check.

@jakubadamw jakubadamw force-pushed the fetch-add-cf-image-property branch from 76593e5 to f2e2846 Compare August 27, 2023 09:36
@jakubadamw jakubadamw force-pushed the fetch-add-cf-image-property branch from f2e2846 to 9482480 Compare November 14, 2023 17:35
@jakubadamw jakubadamw force-pushed the fetch-add-cf-image-property branch from 9482480 to ff9c73e Compare April 30, 2024 09:45
@jakubadamw jakubadamw force-pushed the fetch-add-cf-image-property branch from ff9c73e to bf0128c Compare September 27, 2024 07:19
@jakubadamw jakubadamw force-pushed the fetch-add-cf-image-property branch from bf0128c to e824ba7 Compare October 20, 2024 14:51
@b3ngg
Copy link

b3ngg commented Nov 10, 2024

Any updates? I really need this …

Thanks for doing this @jakubadamw!

@jakubadamw jakubadamw force-pushed the fetch-add-cf-image-property branch from e824ba7 to 890c97c Compare December 11, 2024 22:47
@GodTamIt
Copy link

@jakubadamw @zebp is there anything outstanding left for this change? I'm happy to pick it up and push it through as well if this one's too stale

@jakubadamw jakubadamw force-pushed the fetch-add-cf-image-property branch from 890c97c to b66a2b0 Compare August 30, 2025 17:27
@jakubadamw
Copy link
Contributor Author

jakubadamw commented Aug 30, 2025

@b3ngg, @GodTamIt, I am sorry this was neglected for so long – busy times. I just pushed a new commit, addressing Zeb's feedback from Oct 2023 and bringing this up to date with the current state of the JS API.

guybedford
guybedford previously approved these changes Sep 2, 2025
Copy link
Collaborator

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update here, would be great to land this.

@jakubadamw jakubadamw force-pushed the fetch-add-cf-image-property branch from 0f366f0 to 6fb5497 Compare September 16, 2025 12:02
@guybedford guybedford merged commit c69c028 into cloudflare:main Sep 17, 2025
3 checks passed
@guybedford
Copy link
Collaborator

Thanks for the dedication here! Will go out in the next release in a couple of weeks.

@jakubadamw
Copy link
Contributor Author

Thanks for the dedication here! Will go out in the next release in a couple of weeks.

Thanks so much for the review and helping get this through! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants