Fix instance memory leak #822
Merged
+405
−352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a memory leak when handling multiple instances of durable objects.
The panic handler proxy system stored the instances assuming one-time use, but we need to ensure GC'able reuse.
This resolves that handling by associating each of the proxies lazily with its instance identity, and then instead of reconstructing instances on the panic reset, instead reconstructing instances on the next entrypoint call.
This also inlines a large allocation for memory testing on the local test suite thanks to @lukevalenta's replication. In the process, including miniflare and compat flag updates to properly test finalization.