Skip to content

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Oct 20, 2025

Fixes DEVX-1557

This PR turns on the --x-provision flag by default.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tracked in DEVX-1585
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a stable v3 feature

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2025

🦋 Changeset detected

Latest commit: 19ac2d4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 20, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11030

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11030

miniflare

npm i https://pkg.pr.new/miniflare@11030

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11030

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11030

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11030

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11030

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11030

wrangler

npm i https://pkg.pr.new/wrangler@11030

commit: 19ac2d4

@penalosa penalosa marked this pull request as ready for review October 20, 2025 14:44
@penalosa penalosa requested a review from a team as a code owner October 20, 2025 14:44
@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/provision-by-default might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11030
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 20, 2025
@penalosa penalosa added the skip-v3-pr Skip validation of presence of a v3 backport PR label Oct 20, 2025
@penalosa penalosa force-pushed the penalosa/provision-by-default branch from 038c4d3 to 19ac2d4 Compare October 22, 2025 08:33
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should bother writing to a redirected config at all? It is not a user editable file (normally), it is usually generated by a build too, and so will end up being recreated without the provisioned info anyway.

@penalosa
Copy link
Contributor Author

I wonder if we should bother writing to a redirected config at all? It is not a user editable file (normally), it is usually generated by a build too, and so will end up being recreated without the provisioned info anyway.

I'm not sure I understand what you mean? This PR shouldn't write to the redirected config, I don't think

@petebacondarwin
Copy link
Contributor

I wonder if we should bother writing to a redirected config at all? It is not a user editable file (normally), it is usually generated by a build too, and so will end up being recreated without the provisioned info anyway.

I'm not sure I understand what you mean? This PR shouldn't write to the redirected config, I don't think

Oops I misread the code. I saw the logic that said it didn't write to the user's config file but I made the incorrect assumption that it would write to the redirected one.

Alll good!

@petebacondarwin petebacondarwin merged commit 1a8088a into main Oct 22, 2025
40 of 43 checks passed
@petebacondarwin petebacondarwin deleted the penalosa/provision-by-default branch October 22, 2025 12:07
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Oct 22, 2025
dario-piotrowicz pushed a commit that referenced this pull request Oct 22, 2025
* Enable provisioning

* Create thirty-walls-film.md

* remove .only

* Update thirty-walls-film.md

* Make experimental nature clearer

* Make sure we don't write redirected config bindings to the user config file

* remove only
@lrapoport-cf lrapoport-cf mentioned this pull request Oct 23, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants