-
Notifications
You must be signed in to change notification settings - Fork 1k
Enable provisioning by default #11030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 19ac2d4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
25a7029 to
325c388
Compare
038c4d3 to
19ac2d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should bother writing to a redirected config at all? It is not a user editable file (normally), it is usually generated by a build too, and so will end up being recreated without the provisioned info anyway.
I'm not sure I understand what you mean? This PR shouldn't write to the redirected config, I don't think |
Oops I misread the code. I saw the logic that said it didn't write to the user's config file but I made the incorrect assumption that it would write to the redirected one. Alll good! |
* Enable provisioning * Create thirty-walls-film.md * remove .only * Update thirty-walls-film.md * Make experimental nature clearer * Make sure we don't write redirected config bindings to the user config file * remove only
Fixes DEVX-1557
This PR turns on the
--x-provisionflag by default.