-
Notifications
You must be signed in to change notification settings - Fork 1k
Potentially update local config on wrangler deploy --x-remote-diff-check invocations
#11033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Potentially update local config on wrangler deploy --x-remote-diff-check invocations
#11033
Conversation
🦋 Changeset detectedLatest commit: d8b6378 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
c8ab048 to
890f0aa
Compare
…heck` invocations
890f0aa to
fe7ceba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. Just some notes on the wording.
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| "wrangler": patch | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future (if we change our approach to experimental semvers) this could be minor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right 🤔
I am happy to change it if we want 🙂
| // (the best we can) here | ||
| !targetingEnvironment && | ||
| (await confirm( | ||
| "Would you like to update the local config file with the conflicting remote values?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicting seems a bit of a strong word here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mh.... yeah I see what you mean...
What about just removing it? is Would you like to update the local config file with the remote values? clear? 🤔
Co-authored-by: Pete Bacon Darwin <[email protected]>
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
Addresses #10894 but without including cases when environments are used, such cases are tricky (because the diffing logic needs to understand inheritance and related nuanes) and I figured I'd deal with them in a followup PR.
Basically this PR adds the option to update a config file on

wrangler deploy --x-remote-diff-checkinvocations: