Skip to content

Conversation

@dom96
Copy link
Contributor

@dom96 dom96 commented Oct 21, 2025

I think it was actually a mistake to include these in the first place. If we continue to include them then we'll need to update the deps manually for the templates periodically.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: docs already exist for this
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because:

@dom96 dom96 requested a review from a team as a code owner October 21, 2025 11:27
@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

🦋 Changeset detected

Latest commit: fc5e0d5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11043

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11043

miniflare

npm i https://pkg.pr.new/miniflare@11043

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11043

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11043

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11043

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11043

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11043

wrangler

npm i https://pkg.pr.new/wrangler@11043

commit: fc5e0d5

@dom96 dom96 force-pushed the dominik/remove-lock-from-python-templates branch 2 times, most recently from 76c4d31 to c1257c4 Compare October 21, 2025 13:30
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one inline nit

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 22, 2025
@dom96 dom96 force-pushed the dominik/remove-lock-from-python-templates branch from c1257c4 to fc5e0d5 Compare October 22, 2025 10:21
@dom96 dom96 merged commit 5d9cf0d into main Oct 22, 2025
30 checks passed
@dom96 dom96 deleted the dominik/remove-lock-from-python-templates branch October 22, 2025 11:16
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Oct 22, 2025
@lrapoport-cf lrapoport-cf mentioned this pull request Oct 23, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants