Add observability to asset-worker outer entrypoint RPC methods#13474
Draft
courtney-sims wants to merge 2 commits intocloudflare:mainfrom
Draft
Add observability to asset-worker outer entrypoint RPC methods#13474courtney-sims wants to merge 2 commits intocloudflare:mainfrom
courtney-sims wants to merge 2 commits intocloudflare:mainfrom
Conversation
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #[insert GH or internal issue link(s)].
Describe your change...
The outer entrypoint's RPC methods (unstable_canFetch, unstable_getByETag, unstable_getByPathname, unstable_exists) previously had no error reporting or tracing. That was only configured for the main fetch. When the router-worker called the RPC methods and they threw, the error was invisible.
This was discovered when deploying the loopback changes to staging. Both flamingo edge tests failed, but nothing appeared in Sentry.
A picture of a cute animal (not mandatory, but encouraged)