Skip to content

Conversation

@phj-loopy
Copy link
Contributor

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

This PR improves code clarity and documentation for the Azure Inventory plugin.

Updates

  • README.md

    • Added detailed Scope and Permissions sections for:
      • Azure Functions
      • Azure Container Registries
  • src/plugin/connector/base.py

    • Removed unnecessary comments to simplify the base connector.
  • src/plugin/manager/container_registries/registry_manager.py, src/plugin/manager/functions/instance_manager.py

    • Added comments describing logic steps.

Known issue

@phj-loopy phj-loopy added documentation Improvements or additions to documentation pass/signedoff labels Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

⚠️ @phj-loopy the signed-off-by was not found in the following 2 commits:

  • 493427f: chore: add comments for Functions and Container Registries managers
  • c2907a5: docs: update README with Functions and Container Registries scope/permissions

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

⚠️ @phj-loopy the signed-off-by was not found in the following 2 commits:

  • 493427f: chore: add comments for Functions and Container Registries managers
  • c2907a5: docs: update README with Functions and Container Registries scope/permissions

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <[email protected]>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@lhhyung lhhyung merged commit 26dc8ca into cloudforet-io:master Dec 3, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation fail/signedoff pass/signedoff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants