Move the logic for deleting existing service keys #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiv03
force-pushed
the
move-the-logic-for-deleting-existing-service-keys
branch
from
81d8ea6 to
9fa2d02
Compare
# Conflicts: # multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/DetectDeployedMtaStep.java
Yavor16
requested changes
Jan 15, 2026
...main/java/org/cloudfoundry/multiapps/controller/core/cf/clients/CustomServiceKeysClient.java
Outdated
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/core/cf/clients/CustomServiceKeysClient.java
Outdated
Show resolved
Hide resolved
...-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/util/NameUtil.java
Outdated
Show resolved
Hide resolved
...troller-core/src/test/java/org/cloudfoundry/multiapps/controller/core/util/NameUtilTest.java
Show resolved
Hide resolved
...main/java/org/cloudfoundry/multiapps/controller/process/steps/BuildCloudDeployModelStep.java
Outdated
Show resolved
Hide resolved
| import static org.junit.jupiter.api.Assertions.assertNull; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| class DetectDeployedMtaStepTest extends SyncFlowableStepTest<DetectDeployedMtaStep> { |
Contributor
There was a problem hiding this comment.
Should you add unit tests for updated logic
stiv03
force-pushed
the
move-the-logic-for-deleting-existing-service-keys
branch
from
9fa2d02 to
a831ec1
Compare
Comment on lines
+93
to
+96
| String mtaId = context.getVariable(Variables.MTA_ID); | ||
| String mtaNamespace = context.getVariable(Variables.MTA_NAMESPACE); | ||
|
|
||
| addDetectedExistingServiceKeysToDetectedManagedKeys(mtaId, mtaNamespace, context); |
Contributor
There was a problem hiding this comment.
you are passing the context to addDetectedExistingServiceKeysToDetectedManagedKeys.
just get the mtaId and namespace in the method
| String spaceGuid = context.getVariable(Variables.SPACE_GUID); | ||
| String userGuid = context.getVariable(Variables.USER_GUID); | ||
| OAuth2AccessTokenWithAdditionalInfo token = tokenService.getToken(userGuid); | ||
| CloudCredentials credentials = new CloudCredentials(token, true); |
Contributor
There was a problem hiding this comment.
refreshable is true by default, not needed, even though not used at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.