decrement mount count if unmount fails #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue describe in https://vmw-jira.broadcom.net/browse/TNZ-71700. Following changes are made:
(1) One new custom error type
MountPointNotExistErrorfor wrapping os.ErrNotExist() error.(2) Two new private methods
removeMountPath()anddecrementMountCounton VolumeDriver. This removes code duplication in many places.(3) Will any of the callers fail because of error wrapping? No.
(4) New unit tests are added.
Backward Compatibility
Yes, backward compatible.