fix(ipset): ignore non-kube-router ipsets #1919
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to filter out sets that we are not authoritative for to avoid race conditions with other operators (like Istio) that might be attempting to modify ipsets at the same time.
|
This seems to behave as expected, not modifying Istio ipsets in testing. I went through testing with the steps in this gist. When using the latest image it failed due to the linked issue, but with an image built from this branch everything worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to filter out sets that we are not authoritative for to avoid race conditions with other operators (like Istio) that might be attempting to modify ipsets at the same time.
This still needs some refinement and probably a refactor or two, but wanted to get it out early so that you could test it and see if it actually resolves what you were seeing in #1918. I tried it in my cluster, and after proving that I could see kube-router modifying other ipsets, then applied this change, and saw that it no longer contained references in its output.
FYI @mjnagel @ilrudie
Attempts to fix #1918