-
Notifications
You must be signed in to change notification settings - Fork 1
feat(heureka): adds false positive actions and image version details page #1421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* feat(heureka): adds image details page * chore(heureka): removes image details panel * feat(heureka): navigate from service panel to image details page * chore(heureka): adds changeset * chore(heureka): adjusts tests * chore(heureka): makes navigation checks generic * chore(heureka): makes navigation checks generic * fix(heureka): fixes prettier issue * feat(heureka): improves navigation and url definition * chore(heureka): adjusts test
…pattern for breadcrumb
🦋 Changeset detectedLatest commit: 2f8a510 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
ArtieReus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! this PR is quite lorge 😅. Added some comments
...rvice/ImageDetails/ImageIssuesList/RemediatedIssuesDataRows/RemediatedIssueDataRow/index.tsx
Show resolved
Hide resolved
apps/heureka/src/components/Service/ImageVersionDetails/ImageVersionOccurrences.tsx
Show resolved
Hide resolved
ArtieReus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about to add tests for all of those new components?
… and remediations panel
…stanceEdge in utils
Summary
Adds false positive remediation to Heureka and introduces an image version details page. Users can mark vulnerabilities as false positive from the image details page and revert false positives from the remediated tab, with success/error feedback via inline messages and toasts. The image version details page shows occurrences and vulnerabilities for a specific version. SHA256 identifiers are shortened to 7 characters in breadcrumbs and page titles for readability in the image version details page. Active and remediated vulnerabilities are reflected in the URL, and the remediation history panel state is encoded in the query string.
Changes Made
False positive remediation
FalsePositiveModalwith required description field and validationMessageand local stateRevert false positive
Toastin the panel (aligned with mark-as-false-positive message style)URL routing for image details
vulnerabilitiesList=active|remediated(defaultactive), andvulRemediations=<CVE>when the remediation history panel is open for a CVEImage version details page
/services/$service/images/$image/versions/$versionImageVersionDetailswith version-specific informationImageVersionOccurrencesfor component instances andImageVersionIssuesListfor vulnerabilities of that versionfetchImageVersionsfor version-specific dataImage details page
SHA256 display
getShortSha256()utility (first 7 characters aftersha256:)Tests
FalsePositiveModal,RemediatedIssueDataRow,RemediationHistoryPanel, andRemediatedIssuesDataRowscomponent which are the main components related to support false positive actions implemented in this PR.Related Issues
[Bug](heureka): replace Technical Filter Keys with Display Names in Filter Pills #935
[Task](heureka): Add image version details page #1407
[Task](heureka): Perform false positive action to vulnerabilities in image details page #1408
[Task](heureka): Delete remediated status of vulnerabilities #1409
[Task](heureka): Add remediated vulnerability details panel with the list of remediation action history #1437
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.