Skip to content

Conversation

@ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Oct 11, 2023

This draft PR aims at investigating and fixing downstream CI issues.

@ogrisel ogrisel added the ci downstream Signal the CI to run the test suite of all registered cloudpickle downstream projects. label Oct 11, 2023
@jrbourbeau
Copy link
Member

Thanks @ogrisel -- see #518 for distributed-related fixes

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (604122c) 83.44% compared to head (68e0ac8) 83.44%.

❗ Current head 68e0ac8 differs from pull request most recent head ac976c5. Consider uploading reports for the commit ac976c5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #519   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files           4        4           
  Lines         725      725           
  Branches      157      157           
=======================================
  Hits          605      605           
  Misses         95       95           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ogrisel ogrisel marked this pull request as ready for review October 12, 2023 13:29
@ogrisel
Copy link
Contributor Author

ogrisel commented Oct 12, 2023

Everything should be fixed now. I am waiting for the last CI run to complete and will merge this PR to master to be able to merge and run downstream CI in #517.

@ogrisel
Copy link
Contributor Author

ogrisel commented Oct 12, 2023

test_client_worker failed but it's time related so hopefully it's just a random failure caused by a slow CI worker.

...
         while (
            sps.client_subscribers
            or any(aps.publish_to_scheduler.values())
            or any(bps.publish_to_scheduler.values())
        ):
            await asyncio.sleep(0.01)
>           assert time() < start + 3
E           assert 1697117888.3903627 < (1697117885.3808994 + 3)
E            +  where 1697117888.3903627 = time()

@ogrisel ogrisel merged commit 45dcb75 into cloudpipe:master Oct 12, 2023
@ogrisel ogrisel deleted the fix-downstream-ci-again branch October 12, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci downstream Signal the CI to run the test suite of all registered cloudpickle downstream projects.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants