Skip to content

Correct Auth0 Parameter Intention #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 5, 2024
Merged

Correct Auth0 Parameter Intention #1107

merged 8 commits into from
Sep 5, 2024

Conversation

milldr
Copy link
Member

@milldr milldr commented Sep 4, 2024

what

  • Removed duplicated SSM parameters for Auth0 Tenant
  • Added SSM parameter for Auth0 App's Client ID wherever it's deployed
  • Create client credentials for auth0 apps

why

  • Originally the requested parameters were misunderstood. We want to create a client ID for each new Auth0 app. We don't need to duplicate the tenant parameters

references

  • customer engagment

@milldr milldr requested review from a team as code owners September 4, 2024 21:10
@milldr milldr enabled auto-merge (squash) September 4, 2024 21:14
goruha
goruha requested changes Sep 4, 2024
View reviewed changes
milldr and others added 5 commits September 4, 2024 17:49
@milldr @goruha
Update main.tf
2372c86 
Co-authored-by: Igor Rodionov  <[email protected]>
@milldr @goruha
Update main.tf
a166932 
Co-authored-by: Igor Rodionov  <[email protected]>
@milldr @goruha
Update main.tf
15f1338 
Co-authored-by: Igor Rodionov  <[email protected]>
@milldr @goruha
Update main.tf
dfbbc58 
Co-authored-by: Igor Rodionov  <[email protected]>
@milldr @goruha
Update main.tf
cfcecda 
Co-authored-by: Igor Rodionov  <[email protected]>
@goruha
Copy link
Member

goruha commented Sep 4, 2024

@milldr

bats failed

Test: check if terraform code needs formatting
File: lint.bats
---------------------------------
main.tf
---------------------------------

@milldr milldr merged commit 53728bc into main Sep 5, 2024
3 checks passed
@milldr milldr deleted the feat/auth0-corrections branch September 5, 2024 08:12
goruha pushed a commit to cloudposse-terraform-components/aws-auth0-app that referenced this pull request Nov 27, 2024
@milldr
Correct Auth0 Parameter Intention (cloudposse/terraform-aws-component…
5ce8060 
…s#1107)
goruha pushed a commit to cloudposse-terraform-components/aws-auth0-connection that referenced this pull request Nov 27, 2024
@milldr
Correct Auth0 Parameter Intention (cloudposse/terraform-aws-component…
951a00d 
…s#1107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goruha goruha goruha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milldr @goruha