Skip to content

upstream tailscale #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 1, 2024
Merged

upstream tailscale #835

merged 9 commits into from
Oct 1, 2024

Conversation

@Benbentwo
Copy link
Member

@Benbentwo Benbentwo commented Aug 23, 2023

what

  • Initial Tailscale deployment

why

  • tailscale operators

references

@Benbentwo Benbentwo requested review from a team as code owners August 23, 2023 20:42
bridgecrew[bot]
bridgecrew bot reviewed Jan 10, 2024
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

@Benbentwo Benbentwo enabled auto-merge (squash) October 1, 2024 17:19
dudymas
dudymas reviewed Oct 1, 2024
View reviewed changes
dudymas
dudymas approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@dudymas dudymas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dudymas
Copy link
Contributor

dudymas commented Oct 1, 2024

Also worth noting that tflint had these warnings:

Warning: [Fixable] local.routes is declared but not used (terraform_unused_declarations)
Warning: [Fixable] variable "helm_manifest_experiment_enabled" is declared but not used (terraform_unused_declarations)
Warning: [Fixable] variable "chart_values" is declared but not used (terraform_unused_declarations)
Warning: [Fixable] variable "create_namespace" is declared but not used (terraform_unused_declarations)
Warning: [Fixable] variable "kube_secret" is declared but not used (terraform_unused_declarations)
Warning: [Fixable] variable "env" is declared but not used (terraform_unused_declarations)

@Benbentwo Benbentwo merged commit 3e47d0f into main Oct 1, 2024
4 checks passed
@Benbentwo Benbentwo deleted the upstream/tailscale branch October 1, 2024 17:49
goruha added a commit to cloudposse-terraform-components/aws-eks-tailscale that referenced this pull request Nov 27, 2024
@Benbentwo @dudymas @goruha
upstream tailscale (cloudposse/terraform-aws-components#835)
e759d86 
Co-authored-by: Jeremy White <[email protected]>
Co-authored-by: Igor Rodionov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@dudymas dudymas dudymas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Benbentwo @dudymas @goruha