feat(hz): support append_location when append_key = ''#1285
Open
zhaozhihom wants to merge 1 commit intocloudwego:developfrom
Open
feat(hz): support append_location when append_key = ''#1285zhaozhihom wants to merge 1 commit intocloudwego:developfrom
zhaozhihom wants to merge 1 commit intocloudwego:developfrom
Conversation
|
zhaozhihong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1285 +/- ##
===========================================
- Coverage 73.17% 72.21% -0.97%
===========================================
Files 138 138
Lines 13533 16137 +2604
===========================================
+ Hits 9903 11653 +1750
- Misses 3035 3887 +852
- Partials 595 597 +2 ☔ View full report in Codecov by Sentry. |
Contributor
|
Hi, @zhaozhihom, may I ask more about the background? Specifically, the scenario where append_key is neither 'method' nor 'service'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Support append_location when append_key is not 'method' or 'service'.
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: Support append_location when append_key is not 'method' or 'service'
zh(optional): 当append_key不等于'method'或'service'的时候,支持从append_location插入内容
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: