-
Notifications
You must be signed in to change notification settings - Fork 200
Update correctionlib to 2.7 #9907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: IB/CMSSW_13_1_X/master
Are you sure you want to change the base?
Conversation
Backporting to older CMSSW versions before we auto-update packages regularly
|
A new Pull Request was created by @nsmith- for branch IB/CMSSW_13_1_X/master. @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
@nsmith- , this should first go in to development IB, i.e. CMSSW_15_1_X, before backporting it to production releases like CMSWW_13.1.X. Can you please open a PR for IB/cMSSW_15_1_X/master branch? |
|
@smuzaffar the version of correctionlib is already at a much more recent version in the the development IB: Line 66 in c4e8bac
This is a backport. If the issue is with 2.6.4 vs. 2.7 I can also bump it to 2.7 there as well |
@nsmith- , yes please first bump it in 15.1.X. also I see you have added few more pip packages . Make sure to get those updates for 15.1.X too and note that newly added packages are not build automatically. You have to add them as dependency of package which actually need/use these |
|
It looks like another auto-update to 15_1_X has happened in the meantime and now correctionlib is v2.7 there: |
All those are just dependencies declared by the package or its dependencies. Again, in 15_1_X, they are all already there. I don't really understand what you are saying here. Why can't we just let pip resolve the environment from this requirements file? |
Backporting to older CMSSW versions before we auto-update packages regularly.
If this works well and is correct I'll propagate it to other versions.