Skip to content

Conversation

@nsmith-
Copy link

@nsmith- nsmith- commented Jun 2, 2025

Backporting to older CMSSW versions before we auto-update packages regularly.
If this works well and is correct I'll propagate it to other versions.

Backporting to older CMSSW versions before we auto-update packages regularly
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2025

A new Pull Request was created by @nsmith- for branch IB/CMSSW_13_1_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor

@nsmith- , this should first go in to development IB, i.e. CMSSW_15_1_X, before backporting it to production releases like CMSWW_13.1.X. Can you please open a PR for IB/cMSSW_15_1_X/master branch?

@nsmith-
Copy link
Author

nsmith- commented Jun 2, 2025

@smuzaffar the version of correctionlib is already at a much more recent version in the the development IB:

correctionlib==2.6.4

This is a backport. If the issue is with 2.6.4 vs. 2.7 I can also bump it to 2.7 there as well

@smuzaffar
Copy link
Contributor

If the issue is with 2.6.4 vs. 2.7 I can also bump it to 2.7 there as well

@nsmith- , yes please first bump it in 15.1.X.

also I see you have added few more pip packages . Make sure to get those updates for 15.1.X too and note that newly added packages are not build automatically. You have to add them as dependency of package which actually need/use these

@iarspider iarspider changed the base branch from IB/CMSSW_13_1_X/master to IB/CMSSW_16_0_X/master September 11, 2025 09:19
@iarspider iarspider changed the base branch from IB/CMSSW_16_0_X/master to IB/CMSSW_13_1_X/master September 11, 2025 09:19
@nsmith-
Copy link
Author

nsmith- commented Sep 30, 2025

It looks like another auto-update to 15_1_X has happened in the meantime and now correctionlib is v2.7 there:
https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_15_1_X/master/pip/requirements.txt#L70
So are we ok to backport this now?

@nsmith-
Copy link
Author

nsmith- commented Sep 30, 2025

also I see you have added few more pip packages . Make sure to get those updates for 15.1.X too and note that newly added packages are not build automatically. You have to add them as dependency of package which actually need/use these

All those are just dependencies declared by the package or its dependencies. Again, in 15_1_X, they are all already there. I don't really understand what you are saying here. Why can't we just let pip resolve the environment from this requirements file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants