Skip to content

Updated SoA View accessors from raw pointers to span #48377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

Updated SoA View accessors from raw pointers to span #48377

merged 1 commit into from
Oct 1, 2025

Conversation

leobeltra
Copy link

@leobeltra leobeltra commented Jun 20, 2025 •
edited
Loading

PR description:

This PR updates the column accessors in the View from raw pointers to std::span<T>, providing automatic range checking. Adjustments have also been made in CMSSW to support this new approach. This PR is dependent on #48216, so it should be merged after that.

PR validation:

The unit tests in CMSSW still pass.

@cmsbuild cmsbuild added this to the CMSSW_15_1_X milestone Jun 20, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48377/45264

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @leobeltra for master.

It involves the following packages:

  • CUDADataFormats/TrackingRecHit (heterogeneous, reconstruction)
  • CondFormats/EcalObjects (db, alca)
  • CondFormats/HGCalObjects (db, upgrade, alca)
  • CondFormats/HcalObjects (db, alca)
  • DQM/SiPixelHeterogeneous (dqm)
  • DataFormats/HGCalDigi (upgrade, simulation)
  • DataFormats/HGCalRecHit (upgrade, reconstruction)
  • DataFormats/HGCalReco (upgrade, reconstruction)
  • DataFormats/ParticleFlowReco (reconstruction)
  • DataFormats/Portable (heterogeneous)
  • DataFormats/PortableTestObjects (heterogeneous)
  • DataFormats/SiPixelDigi (simulation)
  • DataFormats/SiPixelDigiSoA (heterogeneous, reconstruction)
  • DataFormats/SoATemplate (heterogeneous)
  • DataFormats/TrackingRecHitSoA (heterogeneous, reconstruction)
  • EventFilter/EcalRawToDigi (reconstruction)
  • HeterogeneousCore/AlpakaTest (heterogeneous)
  • HeterogeneousCore/CUDATest (heterogeneous)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalCalo/HGCalRecAlgos (upgrade, reconstruction)
  • RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)
  • RecoLocalCalo/HcalRecProducers (reconstruction)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoParticleFlow/PFClusterProducer (reconstruction)
  • RecoParticleFlow/PFRecHitProducer (reconstruction)
  • RecoTauTag/HLTProducers (hlt)
  • RecoTracker/LSTCore (reconstruction)
  • RecoTracker/PixelSeeding (reconstruction)
  • RecoTracker/PixelTrackFitting (reconstruction)
  • RecoTracker/TkSeedGenerator (reconstruction)
  • RecoVertex/PixelVertexFinding (reconstruction)

@Martin-Grunewald, @Moanwar, @antoniovagnerini, @atpathak, @civanch, @cmsbuild, @ctarricone, @francescobrivio, @fwyzard, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @perrotta, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @VinInn, @VourMa, @abdoulline, @apsallid, @argiro, @azotz, @bsunanda, @cseez, @denizsun, @dgulhan, @dkotlins, @edjtscott, @fabiocos, @felicepantaleo, @ferencek, @fioriNTU, @gpetruc, @hatakeyamak, @idebruyn, @jandrea, @lecriste, @lgray, @makortel, @mariadalfonso, @martinamalberti, @mbluj, @missirol, @mmarionncern, @mmusich, @mroguljic, @mtosi, @pfs, @rchatter, @rovere, @rsreds, @salimcerci, @sameasy, @seemasharmafnal, @sethzenz, @thomreis, @threus, @tocheng, @tsusa, @tvami, @vandreev11, @wang0jin, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jun 20, 2025

type ngt

@mmusich
Copy link
Contributor

mmusich commented Jun 20, 2025

enable gpu

@mmusich
Copy link
Contributor

mmusich commented Jun 20, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Jun 20, 2025

allow @leobeltra test rights

@leobeltra leobeltra changed the title Updated SoA accessors view from raw pointers to span Updated SoA View accessors from raw pointers to span Jun 20, 2025
@cmsbuild cmsbuild mentioned this pull request Jun 20, 2025
Merged
@jfernan2
Copy link
Contributor

Reco is fine with the changes, I will propagate the info to the POGs even though most of them are already tagged in this PR

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f8d28/48341/summary.html
COMMIT: fbce99f
CMSSW: CMSSW_16_0_X_2025-09-29-1100/el8_amd64_gcc12
Additional Tests: GPU,AMD_MI300X,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48377/48341/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4153945
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4153887
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 226 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

NVIDIA_H100 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 261 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 146188
  • DQMHistoTests: Total failures: 28809
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 117372
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 42 log files, 45 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

NVIDIA_T4 Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2025

+hlt

  • changes in RecoTauTag/HLTProducers are minimal and coherent with the rest of the PR.

@civanch
Copy link
Contributor

civanch commented Sep 30, 2025

+simulation

@gabrielmscampos
Copy link
Member

+dqm

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 1, 2025

+1

@fwyzard
Copy link
Contributor

fwyzard commented Oct 1, 2025

@cms-sw/upgrade-l2 may I ask you to (review and) sign ?
thanks !

@Moanwar
Copy link
Contributor

Moanwar commented Oct 1, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 031c130 into cms-sw:master Oct 1, 2025
22 checks passed
This was referenced Oct 1, 2025
Open
Merged
@GNiendorf GNiendorf mentioned this pull request Oct 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

6 more reviewers

@rovere rovere rovere left review comments

@fwyzard fwyzard fwyzard left review comments

@thomreis thomreis thomreis left review comments

@slava77 slava77 slava77 left review comments

@VourMa VourMa VourMa left review comments

@GNiendorf GNiendorf GNiendorf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

allow-leobeltra code-checks-approved dqm-approved fully-signed heterogeneous-approved hlt-approved ngt orp-approved reconstruction-approved simulation-approved tests-approved tracking trk upgrade-approved

Projects

None yet

Milestone

CMSSW_16_0_X

Development

Successfully merging this pull request may close these issues.