[HGCAL] Add ECON-T indexer for reading out TPG data

[MijaToka]

PR description:

This PR adds an ECON-T Module indexer for the Trigger cells following the DAQ structure for reading out TPG data at the cassette testing in September.

Added:

• Module indexer for the trigger cells in CondFormats.
• SoA Data structures in CondFormats to map the trigger cells and modules (HGCalMappingModuleTriggerParamSoALayout, HGCalDenseIndexTriggerInfoSoALayout) + HGCalDigiTriggerSoALayout to DataFormats for storing trigger cell data
• EDProducer Geometry/HGCalMapping/test/HGCalMappingTriggerESSourceTester.cc as a tester.

The indexer was presented here and discussed here in plans for TPG at the cassette testing in September.

PR validation:

To test, a tester was created and DQM validation was performed with test beam data (last slide).

This tester uses depends of a modulelocator_trigger_test.txt in PR to cms-data.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48648/45642

• There are other open Pull requests which might conflict with changes you have proposed:
  • File CondFormats/HGCalObjects/interface/HGCalMappingParameterSoA.h modified in PR(s): Adapt HGCal rechit producer for HGCal testbeam data #48606

[cmsbuild]

A new Pull Request was created by @MijaToka for master.

It involves the following packages:

• CondFormats/HGCalObjects (alca, upgrade, db)
• DataFormats/HGCalDigi (simulation, upgrade)
• Geometry/HGCalMapping (upgrade, geometry)

@Dr15Jones, @Moanwar, @atpathak, @bsunanda, @civanch, @cmsbuild, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @perrotta, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @bsunanda, @fabiocos, @martinamalberti, @missirol, @mmusich, @rovere, @rsreds, @seemasharmafnal, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

-1

Failed Tests: HeaderConsistency
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6472a/47480/summary.html
COMMIT: d41dc2b
CMSSW: CMSSW_15_1_X_2025-07-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48648/47480/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4076122
• DQMHistoTests: Total failures: 21
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4076081
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[pfs]

I think it's ok now, after passing the full set of parameters to the bot. can we get the remaining signatures? maybe we're still in time for the first 16x release. First beam expected today and this PR integrated will help :)

[pfs]

Just a note: it was a bit hard for me to find the results with GPU. Apparently the bot ran several workflows. But it did run 77.0 as e.g. here. It looks like there's something to tweak in the test parameters above to restrict to workflow 77.0 only.

[perrotta]

+1

[perrotta]

Just a note: it was a bit hard for me to find the results with GPU. Apparently the bot ran several workflows. But it did run 77.0 as e.g. here. It looks like there's something to tweak in the test parameters above to restrict to workflow 77.0 only.

It was never intended to run wf 77 only, but wf 77 in addition to the other usual workflows

[pfs]

ah thanks for the clarification @perrotta !

[civanch]

+1

[IzaakWN]

Hi @cms-sw/upgrade-l2, could you have a final look and sign off, please? It would greatly facilitate the ongoing HGCal cassette testing and test beam if this makes it in the new release.

[Moanwar]

+Upgrade

[perrotta]

+Upgrade

@Moanwar this signature was not recognized
Perhaps with lower case "u"?
(Or maybe release managers can just give it for good: @mandrenguyen @ftenchini )

[Moanwar]

+Upgrade

@Moanwar this signature was not recognized Perhaps with lower case "u"? (Or maybe release managers can just give it for good: @mandrenguyen @ftenchini )

Hi @perrotta , it should be as it's +Upgrade , this is wired!!

[Moanwar]

+Upgrade

Let's try again 🤷‍♂️

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[pfs]

thanks all for the help getting this reviewed and integrated