Skip to content

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 14, 2025

backport of #48886

PR description:

From the original PR description:

In the context of the Next Generation Triggers Task 3.4 ("Optimal HLT Calibrations") we are interested in speeding up the calibration procedures with the aim of implementing real time calibrations for the phase-2 upgrade HLT.
A stepping stone towards that, consists in the NGT Demonstrator which we plan to deploy and operate during Run 3 (late 2025 and 2026).
The "calibration leg" of such demonstrator is planned to run a trimmed down version of the Prompt Calibration Loop delivering selected alignment and calibrations.
Unfortunately in the current Express / Prompt Calibration Loop reconstruction model a disproportionate amount of resources is spent into reconstructing objects which are not particularly useful for the calibration procedures themselves.
A very prominent amount of time is spent in the higher iterative tracking iterations targeting particularly either displaced or soft tracks.
To boost the timing of the procedure we're interested in having a version of reconstruction that focuses only on prompt and relatively high momentum tracks.
The existing trackingIters01 process modifier is suitable for such purpose, but its usage had to be slightly modified to support the case in which it is not run in conjunction with the modifier trackingPhase2PU140, which is the goal of this PR

PR validation:

Run successfully the following script:

#!/bin/bash -ex                                                                                                                                                                                             

file_list="file:/eos/user/j/jprendi/repacked_files/repacked_0.root,file:/eos/user/j/jprendi/repacked_files/repacked_1.root,file:/eos/user/j/jprendi/repacked_files/repacked_10.root,file:/eos/user/j/jprendi/repacked_files/repacked_11.root,file:/eos/user/j/jprendi/repacked_files/repacked_12.root,file:/eos/user/j/jprendi/repacked_files/repacked_13.root,file:/eos/user/j/jprendi/repacked_files/repacked_14.root,file:/eos/user/j/jprendi/repacked_files/repacked_15.root,file:/eos/user/j/jprendi/repacked_files/repacked_16.root,file:/eos/user/j/jprendi/repacked_files/repacked_17.root,file:/eos/user/j/jprendi/repacked_files/repacked_18.root,file:/eos/user/j/jprendi/repacked_files/repacked_19.root,file:/eos/user/j/jprendi/repacked_files/repacked_2.root,file:/eos/user/j/jprendi/repacked_files/repacked_20.root,file:/eos/user/j/jprendi/repacked_files/repacked_3.root,file:/eos/user/j/jprendi/repacked_files/repacked_4.root,file:/eos/user/j/jprendi/repacked_files/repacked_5.root,file:/eos/user/j/jprendi/repacked_files/repacked_6.root,file:/eos/user/j/jprendi/repacked_files/repacked_7.root,file:/eos/user/j/jprendi/repacked_files/repacked_8.root,file:/eos/user/j/jprendi/repacked_files/repacked_9.root"

cmsDriver.py expressStep2 \
         --conditions 140X_dataRun3_Express_v3 \
         -s RAW2DIGI,RECO,ALCAPRODUCER:SiStripPCLHistos+SiStripCalZeroBias+SiStripCalMinBias+SiStripCalMinBiasAAG+TkAlMinBias+SiPixelCalZeroBias+SiPixelCalSingleMuon+SiPixelCalSingleMuonTight+TkAlZMuMu \
         --datatier ALCARECO --eventcontent ALCARECO --data --process RECO \
         --scenario pp --era Run3 \
         --nThreads 8 \
         --nStreams 8 \
         --procModifiers trackingIters01 \
         -n 1000 --filein "$file_list" \
         --fileout file:step2.root --no_exec \
         --python_filename expressStep2_RAW2DIGI_RECO_ALCAPRODUCER.py

cat <<@EOF>> expressStep2_RAW2DIGI_RECO_ALCAPRODUCER.py
process.load('HLTrigger.Timer.FastTimerService_cfi')
process.FastTimerService.writeJSONSummary = True
process.FastTimerService.jsonFileName = "timing_tracking_upperbound_s2.json"
@EOF

cmsRun expressStep2_RAW2DIGI_RECO_ALCAPRODUCER.py >& step2.log

In addition I also checked that the previous use of the modifier in phase-2 target workflows still runs, e.g. via:

runTheMatrix.py --what upgrade -l 29634.703,29634.704 -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #48886 to CMSSW_15_1_X for 2025 operation purposes - to be used in the NGT demonstrator workflows.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 14, 2025

type ngt

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2025

A new Pull Request was created by @mmusich for CMSSW_15_0_X.

It involves the following packages:

  • RecoTracker/ConversionSeedGenerators (reconstruction)
  • RecoTracker/FinalTrackSelectors (reconstruction)
  • RecoTracker/IterativeTracking (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 14, 2025

test parameters:

  • relval_opts = -w upgrade
  • workflows = 29634.703,29634.704

@mmusich
Copy link
Contributor Author

mmusich commented Sep 14, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4523e6/48102/summary.html
COMMIT: 75cf61d
CMSSW: CMSSW_15_0_X_2025-09-14-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48923/48102/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4200660
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4200634
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 230 log files, 200 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants