-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[NGT] Add extra NGT scouting track table producer, when using NANO:@NGTScoutingVal
#48935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
type ngt |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48935/46095 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
9ea9ddb
to
f765a89
Compare
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48935/46135 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
f765a89
to
e884bfb
Compare
e884bfb
to
acb3675
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48935/46147 |
Pull request #48935 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again. |
@cmsbuild, please test |
+1 Size: This PR adds an extra 24KB to repository
Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+hlt |
@cmsbuild ping |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title says it all, add by default to all
NANO:@NGTScouting
flavors the following variables:dxyError()
dzError()
In addition, when running
NANO:@NGTScoutingVal
add a complementary Table producer calledHLTTracksExtraTableProducer
that at the moment fills the track impact parameters w.r.t. the Beam Spot, but it is foreseen to hold more information.PR validation:
Run successfully:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A