Skip to content

Conversation

@akritkbehera
Copy link
Contributor

Fixed build errors and warnings in HGCalMapping tests and MkFit plugin.

Added the dependencies in BuildFile.xml:

  • Geometry/HGCalGeometry, Geometry/HGCalCommonData, Geometry/CaloTopology for HGCalMapping tests.
  • RecoTracker/MeasurementDet for MkFit plugin.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @akritkbehera for master.

It involves the following packages:

  • Geometry/HGCalMapping (geometry)
  • RecoTracker/MkFit (reconstruction)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @IzaakWN, @VinInn, @VourMa, @bsunanda, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @gpetruc, @makortel, @martinamalberti, @mmasciov, @mmusich, @mtosi, @pfs, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@akritkbehera akritkbehera changed the title [UBSAN_X] Fixed build errors and warnings in HGCalMapping tests and MkFit plugin. [UBSAN_X] Added missing <use> dependencies in BuildFile.xml for HGCalMapping tests and MkFit plugin Nov 21, 2025
@akritkbehera
Copy link
Contributor Author

please test for CMSSW_16_0_UBSAN_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2c9ff/49591/summary.html
COMMIT: 4e60a80
CMSSW: CMSSW_16_0_UBSAN_X_2025-11-19-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49431/49591/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2c9ff/49591/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2c9ff/49591/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test pytorch-test_simple_dnn had ERRORS

@akritkbehera
Copy link
Contributor Author

The failing test is fixed by PyTorch: fixed typo in BuildFile.

@jfernan2
Copy link
Contributor

please test with #49428 for CMSSW_16_0_UBSAN_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2c9ff/49631/summary.html
COMMIT: 4e60a80
CMSSW: CMSSW_16_0_UBSAN_X_2025-11-21-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49431/49631/install.sh to create a dev area with all the needed externals and cmssw changes.

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Nov 25, 2025

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 75fc02c into cms-sw:master Nov 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants