Specialise `Handle` and `OrphanHandle` for `WrapperBase` #49449

fwyzard · 2025-11-23T18:59:44Z

PR description:

Specialise Handle and OrphanHandle for WrapperBase: this lets user code produce and consume collections via their wrapper, using their run time type information (e.g. type name, type id, ...) instead of the compile time types.

Implement a new integration test for this specialisations.

PR validation:

The new tests pass.

cmsbuild · 2025-11-23T19:00:07Z

cms-bot internal usage

fwyzard · 2025-11-23T19:00:33Z

This is the Handle part of #47504, that is also needed for the plugin-based approach.

fwyzard · 2025-11-23T19:00:38Z

type ngt

fwyzard · 2025-11-23T19:01:40Z

urgent

#47504 is open since over 8 months... can we get this part merged in CMSSW 16.0.0-pre3 ?

fwyzard · 2025-11-23T19:01:50Z

please test

cmsbuild · 2025-11-23T19:02:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49449/46926

There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/interface/WrapperBaseHandle.h modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module #47504, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233
- File FWCore/Framework/interface/WrapperBaseOrphanHandle.h modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module #47504, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233
- File FWCore/Framework/src/WrapperBaseHandle.cc modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module #47504, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/plugins/BuildFile.xml modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module #47504, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/plugins/WrapperBaseProducer.cc modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module #47504, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/test/BuildFile.xml modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module #47504, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/test/testWrapperBaseProducer_cfg.py modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module #47504, Enabling usage of filters in MPI offloading #49233

cmsbuild · 2025-11-23T19:02:39Z

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

FWCore/Framework (core)
FWCore/Integration (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2025-11-23T20:27:13Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b6026/49624/summary.html
COMMIT: 802dd63
CMSSW: CMSSW_16_0_X_2025-11-23-0000/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49449/49624/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 16 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3905633
DQMHistoTests: Total failures: 125
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3905488
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: found differences in 1 / 49 workflows

FWCore/Framework/interface/WrapperBaseHandle.h

FWCore/Framework/interface/WrapperBaseOrphanHandle.h

FWCore/Integration/plugins/WrapperBaseProducer.cc

cmsbuild · 2025-11-25T18:45:23Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49449/46946

There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/interface/WrapperBaseHandle.h modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233
- File FWCore/Framework/interface/WrapperBaseOrphanHandle.h modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233
- File FWCore/Framework/src/WrapperBaseHandle.cc modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/plugins/BuildFile.xml modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/plugins/WrapperBaseProducer.cc modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/test/BuildFile.xml modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/test/testWrapperBaseProducer_cfg.py modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Enabling usage of filters in MPI offloading #49233

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49449/46946/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49449/46946/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

This lets user code produce and consume collections via their wrapper, using their run time type information (e.g. type name, type id, ...) instead of the compile time types. Co-authored-by: Matti Kortelainen <[email protected]>

Co-authored-by: Matti Kortelainen <[email protected]>

fwyzard · 2025-11-25T18:54:31Z

Done, thanks for the suggestions.

fwyzard · 2025-11-25T18:54:34Z

please test

cmsbuild · 2025-11-25T18:56:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49449/46948

There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/interface/WrapperBaseHandle.h modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233
- File FWCore/Framework/interface/WrapperBaseOrphanHandle.h modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233
- File FWCore/Framework/src/WrapperBaseHandle.cc modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Implement a GenericCloner test module based on an edmplugin::PluginFactory #49152, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/plugins/BuildFile.xml modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/plugins/WrapperBaseProducer.cc modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/test/BuildFile.xml modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Enabling usage of filters in MPI offloading #49233
- File FWCore/Integration/test/testWrapperBaseProducer_cfg.py modified in PR(s): Extend CMSSW to a distributed application over MPI #32632, Enabling usage of filters in MPI offloading #49233

cmsbuild · 2025-11-25T18:56:47Z

Pull request #49449 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

cmsbuild · 2025-11-25T20:26:40Z

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b6026/49676/summary.html
COMMIT: 85c6480
CMSSW: CMSSW_16_0_X_2025-11-25-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49449/49676/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 15 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4269665
DQMHistoTests: Total failures: 86
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4269559
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: found differences in 1 / 51 workflows

makortel · 2025-11-25T21:25:42Z

Comparison differences are related to #47071

makortel · 2025-11-25T21:26:10Z

+core

cmsbuild · 2025-11-25T21:26:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

ftenchini · 2025-11-26T09:19:49Z

+1

cmsbuild added this to the CMSSW_16_0_X milestone Nov 23, 2025

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Nov 23, 2025

cmsbuild added the ngt label Nov 23, 2025

cmsbuild added tests-started urgent and removed tests-pending labels Nov 23, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 23, 2025

fwyzard mentioned this pull request Nov 23, 2025

Implement a GenericCloner test module #47504

Closed

cmsbuild added tests-approved and removed tests-started labels Nov 23, 2025

makortel reviewed Nov 25, 2025

View reviewed changes

FWCore/Framework/interface/WrapperBaseHandle.h Outdated Show resolved Hide resolved

FWCore/Framework/interface/WrapperBaseOrphanHandle.h Show resolved Hide resolved

FWCore/Integration/plugins/WrapperBaseProducer.cc Outdated Show resolved Hide resolved

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Nov 25, 2025

cmsbuild removed the code-checks-pending label Nov 25, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 25, 2025

fwyzard and others added 2 commits November 25, 2025 19:53

Specialise Handle and OrphanHandle for WrapperBase

49212d7

This lets user code produce and consume collections via their wrapper, using their run time type information (e.g. type name, type id, ...) instead of the compile time types. Co-authored-by: Matti Kortelainen <[email protected]>

Implement integration tests for WrapperBase specialisations

85c6480

Co-authored-by: Matti Kortelainen <[email protected]>

fwyzard force-pushed the WrapperBaseHandle branch from 44bad76 to 85c6480 Compare November 25, 2025 18:54

cmsbuild added tests-started code-checks-pending and removed tests-pending code-checks-rejected labels Nov 25, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 25, 2025

cmsbuild added tests-approved and removed tests-started labels Nov 25, 2025

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Nov 25, 2025

fwyzard mentioned this pull request Nov 25, 2025

Trivial serialisation plugin mechanism #49475

Open

cmsbuild added orp-approved and removed orp-pending labels Nov 26, 2025

cmsbuild merged commit f5bb039 into cms-sw:master Nov 26, 2025
10 checks passed

Specialise Handle and OrphanHandle for WrapperBase #49449

Specialise Handle and OrphanHandle for WrapperBase #49449

Uh oh!

Conversation

fwyzard commented Nov 23, 2025

PR description:

PR validation:

Uh oh!

cmsbuild commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fwyzard commented Nov 23, 2025

Uh oh!

fwyzard commented Nov 23, 2025

Uh oh!

fwyzard commented Nov 23, 2025

Uh oh!

fwyzard commented Nov 23, 2025

Uh oh!

cmsbuild commented Nov 23, 2025

Uh oh!

cmsbuild commented Nov 23, 2025

Uh oh!

cmsbuild commented Nov 23, 2025

Comparison Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented Nov 25, 2025

Uh oh!

fwyzard commented Nov 25, 2025

Uh oh!

fwyzard commented Nov 25, 2025

Uh oh!

cmsbuild commented Nov 25, 2025

Uh oh!

cmsbuild commented Nov 25, 2025

Uh oh!

cmsbuild commented Nov 25, 2025

Comparison Summary

Uh oh!

makortel commented Nov 25, 2025

Uh oh!

makortel commented Nov 25, 2025

Uh oh!

cmsbuild commented Nov 25, 2025

Uh oh!

ftenchini commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Specialise `Handle` and `OrphanHandle` for `WrapperBase` #49449

Specialise `Handle` and `OrphanHandle` for `WrapperBase` #49449

cmsbuild commented Nov 23, 2025 •

edited

Loading